We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the bug GLTFModel caches some typed array data for buffer views, which is never used.
Within GLTFModel's loadBufferView() function we need to remove the lines between the REMOVE comments below:
loadBufferView()
function loadBufferView(ctx, bufferViewInfo) { var buffer = ctx.json.buffers[bufferViewInfo.buffer]; bufferViewInfo._typedArray = null; var byteLength = bufferViewInfo.byteLength || 0; var byteOffset = bufferViewInfo.byteOffset || 0; bufferViewInfo._buffer = buffer._buffer.slice(byteOffset, byteOffset byteLength); // REMOVE if (bufferViewInfo.target === 34963) { bufferViewInfo._typedArray = new Uint16Array(bufferViewInfo._buffer); } else if (bufferViewInfo.target == 34962) { bufferViewInfo._typedArray = new Float32Array(bufferViewInfo._buffer); / } else { } // REMOVE }
Expected behavior Less memory used while loading glTF files.
The text was updated successfully, but these errors were encountered:
xeolabs
No branches or pull requests
Describe the bug
GLTFModel caches some typed array data for buffer views, which is never used.
Within GLTFModel's
loadBufferView()
function we need to remove the lines between the REMOVE comments below:Expected behavior
Less memory used while loading glTF files.
The text was updated successfully, but these errors were encountered: