Addressed future warnings regarding dataset.dims #984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hub.com/xcube-dev/xcube into clarasb-981-FutureWarnings_dataset_dims
pont-us
approved these changes
May 22, 2024
There was a problem hiding this comment.
Looks fine and works fine! Looks as though it's just in time too.
Just as a note: a few of the dims -> sizes substitutions here were not really necessary. For example in iproc.py:
if "time" in dataset.dims:The impending xarray change won't remove dims, but will change the functionality from returning a dimension->size mapping to a set of dimensions. So tests with the in operator will continue to work.
However, there's also no harm in changing to sizes, since with dicts in checks membership of the set of keys, so the functionality in this case is identical. So this is just an incidental comment rather than a change request :).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #981
Checklist:
Add unit tests and/or doctests in docstringsAdd docstrings and API docs for any new/modified user-facing classes and functionsNew/modified features documented indocs/source/*CHANGES.md