Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamical xcube package name; xcube used for local install, xcube-core used for PyPI #1010

Merged
merged 4 commits into from
Jun 7, 2024

Conversation

konstntokas
Copy link
Contributor

@konstntokas konstntokas commented Jun 7, 2024

This PR changes the package name from xcube-core to xcube in the pyproject.toml. For the automated workflow to release on PyPI, the line where the package name is defined is changed to name = "xcube-core".

The workflow has been tested with TestPyPI (see TestPyPI xcube-core 1.6.0.dev3)

Checklist:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/source/*
  • Changes documented in CHANGES.md
  • GitHub CI passes
  • AppVeyor CI passes
  • Test coverage remains or increases (target 100%)

@konstntokas konstntokas requested a review from forman June 7, 2024 10:42
Copy link
Member

@forman forman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my suggestion. CHANGES.md only contains changes from one release to the other.

CHANGES.md Outdated Show resolved Hide resolved
Co-authored-by: Norman Fomferra <[email protected]>
@konstntokas konstntokas marked this pull request as ready for review June 7, 2024 12:19
@konstntokas konstntokas merged commit 55edb97 into main Jun 7, 2024
3 checks passed
@konstntokas konstntokas deleted the konstntokas-xxx-dynamical_pypi_project_name branch June 7, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants