(feat) add configurable loop count option #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, the PR is absolutely fine, LGTM. Thank you for your contribution! :) |
Thank you very much that's great : ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a configurable
loop_countproperty to thegifos_settings.tomlandgifos.pyTerminal class, with a setter function in the latter.I had a bit of trouble trying to generate a non-looping gif with the library and ended up having to just yoink the call to ffmpeg from the
Terminal.gen_gif()method and change it to add a-loopflag.From
ffmpeg -h muxer=gifthe loop count options are:with a default argument of
0Having the default as zero in both the configuration file as well as the terminal class should mean that default behaviour is unchanged. This is my first ever pull request so let me know if it needs changing or is just terrible.
Thank you for such a fun library!