Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

20240728-EVP_PKEY_is_a #7804

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Conversation

douzzer
Copy link
Contributor

@douzzer douzzer commented Jul 29, 2024

wolfcrypt/src/evp.c: add EVP_PKEY_is_a().

@bandi13
Copy link
Contributor

bandi13 commented Jul 29, 2024

retest this please

Copy link
Member

@julek-wolfssl julek-wolfssl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Needs some unit tests.

@douzzer
Copy link
Contributor Author

douzzer commented Aug 12, 2024

retest this please -- PRB-aarch64-tests-v2 testsuite "wolfSSL error: tcp connect failed: Connection refused"

@douzzer
Copy link
Contributor Author

douzzer commented Aug 13, 2024

retest this please

(unreproducible failure on PRB-fsanitize-addr-v3 ./configure --enable-jobserver=4 CC="clang -fsanitize=address,undefined -g" --enable-all --enable-sp-math-all FAIL: scripts/openssl.test)

@douzzer douzzer assigned julek-wolfssl and unassigned douzzer Aug 13, 2024
Copy link
Member

@julek-wolfssl julek-wolfssl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final fixes and ready to merge.

wolfcrypt/src/evp.c Outdated Show resolved Hide resolved
wolfcrypt/src/evp.c Outdated Show resolved Hide resolved
wolfcrypt/src/evp.c Outdated Show resolved Hide resolved
wolfcrypt/src/evp.c Outdated Show resolved Hide resolved
…_a(). also add test_EVP_CIPHER_key_length() and add missing RC4 clause to wolfSSL_EVP_Cipher_key_length().
@douzzer douzzer removed their assignment Aug 14, 2024
@julek-wolfssl julek-wolfssl merged commit 055d68d into wolfSSL:master Aug 14, 2024
117 of 124 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants