Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Lookup component scrollbar height after open and closing menu #682

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

guergana
Copy link
Contributor

@guergana guergana commented Aug 8, 2023

Note: this is not reproducible in Wikit, please reproduce in special-new-lexeme. Instructions in the phabricator ticket.

Bug: T325822

@github-actions
Copy link

github-actions bot commented Aug 8, 2023

Copy link
Collaborator

@micgro42 micgro42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reproduced this error in storybook on master (with wrapping the added results in a window.setTimeout()) and confirmed that it works as expected with this change.

@guergana
Copy link
Contributor Author

I reproduced this error in storybook on master (with wrapping the added results in a window.setTimeout()) and confirmed that it works as expected with this change.

Super! It didn't occur to me before to test that way ,thanks for the tip.

@guergana guergana merged commit 1114e62 into master Aug 14, 2023
3 of 5 checks passed
@guergana guergana deleted the fix-scrollbar-bug branch August 14, 2023 14:18
guergana added a commit that referenced this pull request Aug 15, 2023
* Fix Lookup component scrollbar height after open and closing menu (#682)

Bug: T325822
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants