Initial load balancing support and test changes #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khvzak
reviewed
Jan 9, 2023
Comment on lines
40
to
44
| fn match_backend<'a>(backends: &'a [Backend], host_header: &str) -> Option<&'a Backend> { | ||
| backends | ||
| .iter() | ||
| .find(|&backend| backend.name.is_some() && host_header == backend.name.clone().unwrap()) | ||
| } |
There was a problem hiding this comment.
You can compare backend.name.as_deref() == Some(host_header) without cloning.
| let backend = match_backend(backends, host_header)?; | ||
|
|
||
| // Check if load balancing is enabled | ||
| if backend.backend_type.is_some() && backend.backend_type.clone()? == "loadbalanced" { |
There was a problem hiding this comment.
No need to clone, see comment for match_backend
Comment on lines
46
to
50
| fn round_robin_select(backend_name: String, backends: &Vec<String>) -> Option<String> { | ||
| // Uses the rr_counter to keep an index of the next backend to select. | ||
| // This counter is incremented or reset to zero when exceeding the number of backends | ||
| let backend_count = backends.len(); | ||
| let mut rr_map = RR_COUNTER.lock().unwrap(); |
There was a problem hiding this comment.
You don't need global counter at all, also this approach can be incorrect under some edge cases.
Would be better to add atomic counter into Backend struct to track number of requests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.