Emulator wrapper fixes #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: detox fails to start when another emulator is running
rotemmiz
requested changes
Apr 30, 2018
| const cmd = _.compact([ | ||
| '-verbose', | ||
| '-gpu', | ||
| 'host', |
There was a problem hiding this comment.
Change to gpu auto for better support. Current command breaks on some machines
|
@rotemmiz , done. |
noomorph
force-pushed
the
fix/emulator-stdout-logging
branch
from
7422075 to
8855370
Compare
|
@rotemmiz , the build is green. |
noomorph
force-pushed
the
fix/emulator-stdout-logging
branch
from
8f93eea to
444477f
Compare
|
The behavior after this pull request is going to be the following:
|
rotemmiz
reviewed
May 2, 2018
| const childProcessPromise = spawn(this.emulatorBin, emulatorArgs, { detached: true, stdio: ['ignore', stdout, stderr] }); | ||
| childProcessPromise.childProcess.unref(); | ||
|
|
||
| return childProcessPromise.catch((err) => { |
There was a problem hiding this comment.
can't this be separated into two declarations ?
childProcessPromise.catch((err) => {
}
....
return childProcessPromise;There was a problem hiding this comment.
But this is completely different logic then. What do you mean?
rotemmiz
approved these changes
May 3, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding (2), there was an issue (likely on Linux, but not sure if it is the reason) with a race condition.
tail.on("line", function(data) {was called too late, when the promise had already rejected.Since the function was returning
return promise;without a catch (e.g.return promise.catch(function () {), thepromise._cpResolve()call was happening too late insidetail.on, when the consumer ofbootlogic actually had gotten into a negative conditional branch.