Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New demo project for react native jest #370

Merged
merged 1 commit into from
Nov 14, 2017
Merged

New demo project for react native jest #370

merged 1 commit into from
Nov 14, 2017

Conversation

SMJ93
Copy link
Contributor

@SMJ93 SMJ93 commented Oct 25, 2017 •
edited
Loading

I've created a new up to date demo project for react native which uses jest as a test runner.

This should help with debugging the jest test runner as it doesn't work for iOS or Android at the moment.

To run:

cd examples/demo-react-native-jest
yarn
npm run test-android
npm run test-ios

@SMJ93 SMJ93 closed this Oct 25, 2017
@SMJ93
Copy link
Contributor Author

SMJ93 commented Oct 25, 2017

Closed as this is included with #371

@SMJ93
Copy link
Contributor Author

SMJ93 commented Oct 30, 2017

@Kureev Here is the demo project without the Jest test runner fix

@SMJ93 SMJ93 reopened this Oct 30, 2017
@SMJ93 SMJ93 mentioned this pull request Oct 30, 2017
Closed
@Kureev
Copy link
Contributor

Kureev commented Oct 30, 2017

Is it blocked by #371?

@SMJ93
Copy link
Contributor Author

SMJ93 commented Oct 30, 2017

@Kureev yep, it's set up to use the fixed jest test runner in #370.

@sibelius
Copy link

sibelius commented Nov 6, 2017

this is great

@sibelius
Copy link

sibelius commented Nov 6, 2017

I think this project example is great https://github.com/mfrachet/detox-example

@rotemmiz
Copy link
Member

@SMJ93 , note 2 I wrote in #371 probably applies here.
What do you say about adding a new build flavor in our matrix and add the demo projects, including this one ? I can help setting it up if you need any help.

@SMJ93
Copy link
Contributor Author

SMJ93 commented Nov 13, 2017

@rotemmiz Yeah, that makes sense. I still think it is useful having an example for Jest separate to the build flavor in the matrix. It's helpful for people starting out with detox and maintaining the Jest test runner.

@Niryo Niryo merged commit 092c499 into wix:master Nov 14, 2017
@wix wix locked and limited conversation to collaborators Jul 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SMJ93 @Kureev @sibelius @rotemmiz @Niryo