-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Screenshot comparison tool recommendations #825
Comments
I don't think this is a good approach. You are relying on many variables to have your screenshots, which you don't control: OS look and feel (fonts, colors, etc.), OS layout and RN layout. All of these are independent and can change with any environment change (such as minor OS version, new RN version, etc.). |
@LeoNatan. I hear you! Changes to screenshots are certainly inevitable and a concern. I think there must be a sustainable way to expect certain changes, but also to catch and reject unexpected changes. This problem reminds me a lot of the discussion around Jest Snapshot Testing. |
Loki provides this for storybook: https://github.com/oblador/loki |
@sibelius Cool! Can you use it for arbitrary image comparison, or only ones generated through storybook? |
Closing this issue. Maintaining such recommendations in docs is out of scope for the project. |
Any recommendations for screenshot comparison tools? This would be great to include in the docs!
I want to upload my screenshots, compare them, and come out with a static link I can send to a designer or PM!
The text was updated successfully, but these errors were encountered: