Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Screenshot comparison tool recommendations #825

Closed
etaiklein opened this issue Jul 12, 2018 · 5 comments
Closed

[Docs] Screenshot comparison tool recommendations #825

etaiklein opened this issue Jul 12, 2018 · 5 comments

Comments

@etaiklein
Copy link

etaiklein commented Jul 12, 2018

Any recommendations for screenshot comparison tools? This would be great to include in the docs!

I want to upload my screenshots, compare them, and come out with a static link I can send to a designer or PM!

@etaiklein etaiklein changed the title [Feature request] Screenshot comparison tool [Docs] Screenshot comparison tool recommendations Jul 12, 2018
@LeoNatan
Copy link
Contributor

I don't think this is a good approach. You are relying on many variables to have your screenshots, which you don't control: OS look and feel (fonts, colors, etc.), OS layout and RN layout. All of these are independent and can change with any environment change (such as minor OS version, new RN version, etc.).

@etaiklein
Copy link
Author

@LeoNatan. I hear you! Changes to screenshots are certainly inevitable and a concern. I think there must be a sustainable way to expect certain changes, but also to catch and reject unexpected changes. This problem reminds me a lot of the discussion around Jest Snapshot Testing.

@sibelius
Copy link

Loki provides this for storybook: https://github.com/oblador/loki

@etaiklein
Copy link
Author

@sibelius Cool! Can you use it for arbitrary image comparison, or only ones generated through storybook?

@LeoNatan
Copy link
Contributor

Closing this issue. Maintaining such recommendations in docs is out of scope for the project.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants