Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing tests pass, afterEach fails #52

Closed
yedidyak opened this issue Dec 1, 2016 · 2 comments
Closed

Failing tests pass, afterEach fails #52

yedidyak opened this issue Dec 1, 2016 · 2 comments
Labels
status: accepted type: bug 🐞

Comments

@yedidyak
Copy link
Contributor

yedidyak commented Dec 1, 2016

When a test fails, the terminal marks it as passed, and the afterEach hook fails.

Expected: Failing tests should fail.
@LeoNatan
Copy link
Contributor

I can verify this occurs when a test fails. There is a bug in the JS mechanism somewhere; could be just a visual glitch in the way things are presented.

@rotemmiz
Copy link
Member

v5 doesn't need to hook on afterEach anymore. Due to its async-await nature it now fails in the appropriate scope.

@wix wix locked and limited conversation to collaborators Jul 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
status: accepted type: bug 🐞
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rotemmiz @LeoNatan @yedidyak @d4vidi