Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no window option for running android emulator with no window #690

Merged
merged 6 commits into from
Apr 29, 2018
Merged

Add no window option for running android emulator with no window #690

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift click to select a range
b2cc22e
Add no window option for running android emulator with no window
yershalom Apr 25, 2018
7fa2383
Change nw flag to W
yershalom Apr 25, 2018
9d8384a
Fix after Rotem review, docs, better explanation and change flag
yershalom Apr 26, 2018
91a9e9b
Change no window to headless flag update cli docs
yershalom Apr 29, 2018
55d6be5
Fix from nowindow to headless Emulator.js
yershalom Apr 29, 2018
835f526
Fix jest params headless
yershalom Apr 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Change nw flag to W
  • Loading branch information
@yershalom
yershalom committed Apr 25, 2018
commit 7fa238384c1a086a1eb5d0e8e4e85f83a893ecb5
2 changes: 1 addition & 1 deletion detox/local-cli/detox-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 34,7 @@ program
'e.g test with substring \':ios:\' in its name will not run when passing \'--platform android\'')
.option('-f, --file [path]',
'Specify test file to run')
.option('-nw, --nowindow',
.option('-W, --nowindow',
'Run Android without window')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.Be as expressive as you can, this is documentation. Text suggestion: "[Android Only] Launch Emulator in headless mode. Useful when running on CI."
2. Update docs (cli section)
3. Why capital W?
4. Let's use same flag as emulator --no-window.
WDYT?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Ok, fixed.
  2. Done.
  3. Right, changed this to -n
  4. --no-window is problematic for how we are doing the flags parsing (as you said). I changed it to --noWindow

.parse(process.argv);

Expand Down