Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actions middleware #9976

Merged
merged 38 commits into from
Nov 13, 2024
Merged

Actions middleware #9976

merged 38 commits into from
Nov 13, 2024

Conversation

TheOtterlord
Copy link
Member

Description (required)

Re-introduces #9943

For Astro version: 5.0. See astro PR withastro/astro#12373.

bholmesdev and others added 30 commits November 7, 2024 11:32
@bholmesdev
replace cookie redirect notices with a custom session guide
e3668b1
@bholmesdev
add since 5.0
fbb6a08
@bholmesdev
add detail to guide code snippets
81937f1
@bholmesdev
add getActionContext() reference
63ac703
@bholmesdev
add 5.0 change
4f54aec
@bholmesdev
nit: session -> sessions
7c5336c
@bholmesdev
fix missing async on cookie example
b154039
@bholmesdev
add security section
8810baf
@bholmesdev
add Since badge for 'gate actions from middleware'
693c088
@bholmesdev
add code formatting
dbe5a15
@bholmesdev
replace build_hash example with session token exampel
3b3c48f
@bholmesdev
nit: remove unused hash variable
2a172c4
@bholmesdev
change list of examples to simpler sentence
8f287e5
@bholmesdev @ArmandPhilippot
remove stray absolute link
d5df652 
Co-authored-by: Armand Philippot <[email protected]>
@bholmesdev @ArmandPhilippot
remove stray absolute link 2
fa270ef 
Co-authored-by: Armand Philippot <[email protected]>
@bholmesdev @ArmandPhilippot
remove stray absolute link 3
9723a27 
Co-authored-by: Armand Philippot <[email protected]>
@bholmesdev @ArmandPhilippot
move Since to after the type def
d41bbfd 
Co-authored-by: Armand Philippot <[email protected]>
@bholmesdev @sarah11918
clarify how the redirect removes the resubmission dialog
1581ab8 
Co-authored-by: Sarah Rainsberger <[email protected]>
@bholmesdev @sarah11918
reword the action return value section
f74350a 
Co-authored-by: Sarah Rainsberger <[email protected]>
@bholmesdev
fix grammar
bc12d81
@bholmesdev @sarah11918
remove misleading "reintroduces
c1a8688 
Co-authored-by: Sarah Rainsberger <[email protected]>
@bholmesdev @sarah11918
add SourcePR label
509b916 
Co-authored-by: Sarah Rainsberger <[email protected]>
@bholmesdev @sarah11918
nit: still -> however
d0db878 
Co-authored-by: Sarah Rainsberger <[email protected]>
@bholmesdev @sarah11918
remove needless example of actions.blog.like
79789b7 
Co-authored-by: Sarah Rainsberger <[email protected]>
@bholmesdev
rework netlify note into paragraph
e9a3fae
@bholmesdev
stop telling people it's easy
2571cb3
@bholmesdev
reword 'Forbidden' to be near the example explanation
4c76da6
@bholmesdev
rephrase 'what should I do?' to recommend sessions
09f6632
@bholmesdev @ArmandPhilippot
ugh
410466e 
Co-authored-by: Armand Philippot <[email protected]>
@bholmesdev @sarah11918
HOWEVER
f12ed6b 
Co-authored-by: Sarah Rainsberger <[email protected]>
@TheOtterlord TheOtterlord added add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) 5.0.0-beta labels Nov 11, 2024
@TheOtterlord TheOtterlord changed the base branch from main to 5.0.0-beta November 11, 2024 18:09
@netlify Netlify
Copy link

netlify bot commented Nov 11, 2024 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 4722704
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/6734b74eace20c0008e09ba0
😎 Deploy Preview https://deploy-preview-9976--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Contributor

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en guides/actions.mdx Source changed, localizations will be marked as outdated.
en guides/upgrade-to/v5.mdx Source changed, localizations will be marked as outdated.
en reference/modules/astro-actions.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@sarah11918 sarah11918 added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label Nov 13, 2024
@sarah11918 sarah11918 merged commit 8f08548 into 5.0.0-beta Nov 13, 2024
5 checks passed
@sarah11918 sarah11918 deleted the actions-middleware branch November 13, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
5.0.0-beta add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TheOtterlord @astrobot-houston @sarah11918 @bholmesdev