Removes mention of hybrid, rewrites rendering pages #9339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sarah11918
commented
Sep 8, 2024
sarah11918
commented
Sep 8, 2024
sarah11918
commented
Sep 8, 2024
sarah11918
commented
Sep 8, 2024
sarah11918
commented
Sep 8, 2024
Co-authored-by: Armand Philippot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
The main changes in this PR are:
removes all mention of
output: 'hybrid', the word "hybrid" etc.Adds a new
/basics/rendering.mdx(replacing rendering modes page) andguides/on-demand-rendering.mdx(replacing server-side rendering page) (new pages, to not deal with i18n fallout yet)updates the nav to point to the new page (but the old one is not yet deleted, for safety, link checker etc.)
updates all the links for the new English pages (no translations were harmed in the making of this PR)
Netlify redirects:
basics/rendering-modes->/basics/rendering/guides/server-side-rendering->/guides/on-demand-renderingNote: Nothing here will affect translations/links right now because I made two new pages and updated the English site accordingly
TODO OUTSIDE OF THIS PR:
Error messages and config reference in the main repo
Need to search for:
/rendering-modes/or/server-side-rendering/(NOTE: anchor links are not necessarily the same on the new pages, so it's not just a hot swap)TODO EVENTUALLY:
I did update some language around the word "hybrid", but I have NOT tried to purge SSR from common usage. For now, it's fine. I'll do it over the course of the beta, and not in time for launch.
I believe this PR is internally consistent for English, and I also believe it doesn't affect the other languages.