feat: Custom server no network dialog #WPB-11627 #3543
Conversation
echoes-hq
bot
added
the
echoes: unplanned
|
| @@ -122,7 125,8 @@ class WireActivityViewModel @Inject constructor( | |||
| private val observeScreenshotCensoringConfigUseCaseProviderFactory: ObserveScreenshotCensoringConfigUseCaseProvider.Factory, | |||
| private val globalDataStore: Lazy<GlobalDataStore>, | |||
| private val observeIfE2EIRequiredDuringLoginUseCaseProviderFactory: ObserveIfE2EIRequiredDuringLoginUseCaseProvider.Factory, | |||
| private val workManager: Lazy<WorkManager> | |||
| private val workManager: Lazy<WorkManager>, | |||
| private val networkStateObserver: Lazy<NetworkStateObserver> | |||
There was a problem hiding this comment.
this is over kill you don't need to check the network state, we can do the request to get the json with custom server meta data and check the error returned it is a network error with something list Io Exception then display this error
There was a problem hiding this comment.
That is unfortunately not doable:
-
When we dont have internet connection and the config is valid we're getting:
GenericError(cause=java.net.UnknownHostException: Unable to resolve host "nginz-https.bund-next-column-offline-android.wire.link": No address associated with hostname) -
When we have internet connection and the config is invalid we're getting:
GenericError(cause=java.net.UnknownHostException: Unable to resolve host "nginz-https.unreachable.wire.link": No address associated with hostname)
So we're unable to know if the config was wrong or not with the exception we're getting
There was a problem hiding this comment.
Maybe we could slightly change the copy and use this dialog in both cases?
Like: "You don't seem to be connected to the Internet or the config link you used is broken. Please check your Internet connection and try again." 😄
There was a problem hiding this comment.
Well yeah we could have only one for malformed json and no internet connection :D that'd solve the issue too
There was a problem hiding this comment.
When we dont have internet connection and the config is valid we're getting:
GenericError(cause=java.net.UnknownHostException: Unable to resolve host "nginz-https.bund-next-column-offline-android.wire.link": No address associated with hostname)
I feel like i am missing something?
this will never happen how was the app able to know that the constant is valid if we are not able to read the content, since there is no internet?
There was a problem hiding this comment.
Changes pushed as we talked today, we now have the no network message for both cases ;)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3543 /- ##
========================================
Coverage 45.77% 45.77%
========================================
Files 472 472
Lines 16024 16025 1
Branches 2705 2705
========================================
Hits 7335 7336 1
Misses 7928 7928
Partials 761 761
Continue to review full report in Codecov by Sentry.
|
m-zagorski
changed the title
|
Built wire-android-staging-compat-pr-3543.apk is available for download |
|
Built wire-android-dev-debug-pr-3543.apk is available for download |
|
|
Built wire-android-staging-compat-pr-3543.apk is available for download |
|
Built wire-android-dev-debug-pr-3543.apk is available for download |
https://wearezeta.atlassian.net/browse/WPB-11627
What's new in this PR?
Issues
When we're trying to connect with custom server and we didnt have internet connection, we didnt display correct popup
Solutions
Due to the matter of handling invalid json being exactly the same as no network, we have to check on our own if we're connected to internet or not. Depending on that we display no network dialog.
Testing
How to Test
Attachments (Optional)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.