Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T236318 Add About Wikipedia Page #187

Merged
merged 7 commits into from
Mar 26, 2020
Merged

T236318 Add About Wikipedia Page #187

merged 7 commits into from
Mar 26, 2020

Conversation

hueitan
Copy link
Member

@hueitan hueitan commented Mar 20, 2020

Phabricator Link: https://phabricator.wikimedia.org/T236318

Note

Reminder that it copies all the image and text from Onboarding page due to the similar content but different UI

Several things can be refactored but can wait

  1. Header for the page can be generalized so we can reuse it in component and css
  2. Let About App and About Wikipedia open as an popup, so user have the previous settings item selected when Close the about page
  3. Reuse the same component for Onboarding and About Wikipedia?
1 2 3
1 2 3

@hueitan hueitan changed the title Add About Wikipedia Page T236318 Add About Wikipedia Page Mar 21, 2020
@jpita
Copy link
Contributor

jpita commented Mar 22, 2020

@hueitan we need a "close" button in the last page otherwise in order to leave the about page the user needs to go all the way back to page 1

@medied
Copy link
Contributor

medied commented Mar 23, 2020

Regarding your refactoring ideas:

Header for the page can be generalized so we can reuse it in component and css

Didn't quite get this, can you explain? Do you mean like a Header component to use across different components (AboutApp, AboutWikipedia, etc)?

Let About App and About Wikipedia open as an popup, so user have the previous settings item selected when Close the about page

Agree with Pita it would be nice to let the user exit AboutWikipedia from the last screen. What about linking a close button at the end to a route('/settings') if we don't have time to refactor to opening as popup?

Reuse the same component for Onboarding and About Wikipedia?

Seems like a good idea, could be a Phabricator task on its own

@hueitan
Copy link
Member Author

hueitan commented Mar 23, 2020

Didn't quite get this, can you explain? Do you mean like a Header component to use across different components (AboutApp, AboutWikipedia, etc)?

It can be a <Header/> component or just the header stay in popup component, the main purpose is to reuse the component so we don't need to apply the same to every component when header is needed.

Agree with Pita it would be nice to let the user exit AboutWikipedia from the last screen. What about linking a close button at the end to a route('/settings') if we don't have time to refactor to opening as popup?

Let's wait for design feedback.

Reuse the same component for Onboarding and About Wikipedia?

Seems like a good idea, could be a Phabricator task on its own

Seems the softkey is different, UI has a bit different, I don't have any good idea now

@hueitan
Copy link
Member Author

hueitan commented Mar 24, 2020

Confirm and done adding center exit key @medied @jpita
https://phabricator.wikimedia.org/T236318#5994143

@jpita jpita merged commit 1f5dd59 into master Mar 26, 2020
@jpita jpita deleted the T236318-About-Wikipedia branch March 26, 2020 04:55
@jpita jpita restored the T236318-About-Wikipedia branch March 26, 2020 05:07
@hueitan hueitan deleted the T236318-About-Wikipedia branch March 3, 2021 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants