-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
T236318 Add About Wikipedia Page #187
Conversation
…36318-About-Wikipedia
@hueitan we need a "close" button in the last page otherwise in order to leave the about page the user needs to go all the way back to page 1 |
Regarding your refactoring ideas:
Didn't quite get this, can you explain? Do you mean like a
Agree with Pita it would be nice to let the user exit
Seems like a good idea, could be a Phabricator task on its own |
It can be a
Let's wait for design feedback.
Seems the softkey is different, UI has a bit different, I don't have any good idea now |
Confirm and done adding center exit key @medied @jpita |
Phabricator Link: https://phabricator.wikimedia.org/T236318
Note
Reminder that it copies all the image and text from Onboarding page due to the similar content but different UI
Several things can be refactored but can wait