New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug with Scylla protocol #346

Merged

whatyouhide merged 2 commits into main from al/fix-bug-with-scylla-protocol

Oct 20, 2023

Owner

whatyouhide commented Oct 20, 2023

Whoopsie dooopsie.


          Fix bug with Scylla protocol

0b9f033

whatyouhide commented

View reviewed changes

lib/xandra/connection.ex

@@ @@ -384,7 384,7 @@ defmodule Xandra.Connection do @@
                       connect_timeout: Keyword.fetch!(options, :connect_timeout),
                       connection_name: Keyword.get(options, :name),
                       cluster_pid: Keyword.get(options, :cluster_pid),
-                      protocol_version: Keyword.get(options, :protocol_version),
+                      protocol_version: data.protocol_version || Keyword.get(options, :protocol_version),

Owner Author

whatyouhide Oct 20, 2023

This is the fix


          More

b475309

whatyouhide merged commit 67f54b0 into main

6 checks passed

whatyouhide deleted the al/fix-bug-with-scylla-protocol branch

October 20, 2023 13:26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet