-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define XPath's lang() as ASCII case-insensitive #1199
Comments
I think it's ok to change it to ASCII case-insensitive. |
Hi Team, Based on GitHub Issue - whatwg/dom#1199 Added comment to not follow 'XPath 3.1' and referenced above issue in comment. - fn-lang.html: Updated to use `unmatch` for U 212A handling case Thanks!
Thanks to @annevk - I have updated WPT test. What would be next steps? |
#67 I suppose. And I guess once we're further along we need some kind of section that defines the subset of XPath we care about. |
Is this intended to be a change to all uses of XPath (including those from XSLT) or only those from the DOM APIs? Also, is the matching intended to follow RFC4647 like selectors does? Chromium's current matching code and Gecko's current matching code appear to do a more naive matching of an initial hyphen-separated sequence. |
I would expect "browser" XPath to be the same in XSLT and through an API. Not sure how much it should follow Selectors. I suspect it should largely follow XPath 1.0 modulo some XPath 2.0 extensions browsers chose to implement. |
For what it's worth, XPath 1.0's definition was vague ("ignoring case") and the definition in XPath 2.0 and the definition in XPath 3.1 specify caseless default match. |
I wrote a CL to make this change in Chrome. |
…low XPath Specification, a=testonly Automatic update from web-platform-tests Update `U 212A` handling case to not follow XPath Specification (#45436) Hi Team, Based on GitHub Issue - whatwg/dom#1199 Added comment to not follow 'XPath 3.1' and referenced above issue in comment. - fn-lang.html: Updated to use `unmatch` for U 212A handling case Thanks! -- wpt-commits: 16f18d8135a80e89f2e910ca7548999fa2f7937e wpt-pr: 45436
…low XPath Specification, a=testonly Automatic update from web-platform-tests Update `U 212A` handling case to not follow XPath Specification (#45436) Hi Team, Based on GitHub Issue - whatwg/dom#1199 Added comment to not follow 'XPath 3.1' and referenced above issue in comment. - fn-lang.html: Updated to use `unmatch` for U 212A handling case Thanks! -- wpt-commits: 16f18d8135a80e89f2e910ca7548999fa2f7937e wpt-pr: 45436
In https://bugs.webkit.org/show_bug.cgi?id=256716 I was made aware of https://wpt.fyi/results/domxpath/fn-lang.html (added in web-platform-tests/wpt@292d532) where apparently Chromium and Gecko follow the XPath 3.1 definition of
lang()
matching which is not in line with how the web platform matches languages.I think it would be better if we define this to be ASCII case-insensitive instead.
cc @tkent-google @petervanderbeken
The text was updated successfully, but these errors were encountered: