Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent shell exit after a successful connection #107

Merged
merged 1 commit into from
Jul 26, 2022
Merged

Prevent shell exit after a successful connection #107

merged 1 commit into from
Jul 26, 2022

Conversation

hyx0329
Copy link
Contributor

@hyx0329 hyx0329 commented Jul 26, 2022 •
edited
Loading

This pr fix issue introduced by 190bc75, close #103.

@hyx0329
Copy link
Contributor Author

hyx0329 commented Jul 26, 2022 •
edited
Loading

Well I think I should overload the Cmd.postcmd(stop, line), as a better approach. Okay it's done.

Let me know if you prefer separated prs.

@hyx0329 hyx0329 changed the title fix cli exit after successfully opening connection [WIP] fix cli exit after successfully opening connection Jul 26, 2022
@hyx0329 hyx0329 changed the title [WIP] fix cli exit after successfully opening connection Prevent shell exit after a successful connection and functional updates Jul 26, 2022
@hyx0329
prevent cmd exiting after a successful connection
c609706 
This commit fix wendlers#103 which causes the command line to exit after successfully
opening a connection.

Signed-off-by: hyx0329 <[email protected]>
@skorokithakis
Copy link
Collaborator

Sorry, separate PRs would be better so I can review each one on its own, would you be able to do that?

@hyx0329
Copy link
Contributor Author

hyx0329 commented Jul 26, 2022

okay, leaving only the one relevant commit

@hyx0329 hyx0329 changed the title Prevent shell exit after a successful connection and functional updates Prevent shell exit after a successful connection Jul 26, 2022
skorokithakis
skorokithakis approved these changes Jul 26, 2022
View reviewed changes
Copy link
Collaborator

@skorokithakis skorokithakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@skorokithakis skorokithakis merged commit b4e47ff into wendlers:master Jul 26, 2022
@skorokithakis
Copy link
Collaborator

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skorokithakis skorokithakis skorokithakis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

version 0.9.2 not work
2 participants
@hyx0329 @skorokithakis