Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 fix: update CSP for GoatCounter #413

Merged
merged 1 commit into from
Oct 18, 2024
Merged

🐛 fix: update CSP for GoatCounter #413

merged 1 commit into from
Oct 18, 2024

Conversation

noeddl
Copy link
Contributor

@noeddl noeddl commented Oct 18, 2024

Summary

This PR changes connect-src in the CSP for GoatCounter to include [analytics.id].goatcounter.com/count instead of gc.zgo.at ( see https://www.goatcounter.com/help/csp).

Related issue

Changes

Accessibility

Screenshots

Type of change

  • Bug fix (fixes an issue without altering functionality)
  • New feature (adds non-breaking functionality)
  • Breaking change (alters existing functionality)
  • UI/UX improvement (enhances user interface without altering functionality)
  • Refactor (improves code quality without altering functionality)
  • Documentation update
  • Other (please describe below)

Checklist

  • I have verified the accessibility of my changes
  • I have tested all possible scenarios for this change
  • I have updated theme.toml with a sane default for the feature
  • I have made corresponding changes to the documentation:
    • Updated config.toml comments
    • Updated theme.toml comments
    • Updated "Mastering tabi" post in English
    • (Optional) Updated "Mastering tabi" post in Spanish
    • (Optional) Updated "Mastering tabi" post in Catalan

@noeddl noeddl requested a review from welpo as a code owner October 18, 2024 14:01
@netlify Netlify
Copy link

netlify bot commented Oct 18, 2024 •
edited
Loading

✅ Deploy Preview for tabi-demo ready!

Name Link
🔨 Latest commit cf9b41b
🔍 Latest deploy log https://app.netlify.com/sites/tabi-demo/deploys/67126a31db43ab0008c47405
😎 Deploy Preview https://deploy-preview-413--tabi-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@welpo welpo added the bug Something isn't working label Oct 18, 2024
@welpo
Copy link
Owner

welpo commented Oct 18, 2024

Thank you!

@welpo welpo merged commit 34514c1 into welpo:main Oct 18, 2024
6 of 7 checks passed
@noeddl noeddl deleted the fix-csp-goatcounter branch October 18, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@welpo welpo Awaiting requested review from welpo welpo is a code owner

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noeddl @welpo