Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow writing of entry when full uncompressed size is not known. #276

Open
wants to merge 4 commits into
base: development
Choose a base branch
from

Conversation

ps2
Copy link

@ps2 ps2 commented May 8, 2023

Some situations require streaming compression where the full size of the input/uncompressed data is not known, such as serializing a large number of objects where loading all the objects into memory would be prohibitive.

Changes proposed in this PR

  • Allow creation of entries without specifying an uncompressedSize

I assume the progress feedback functionality will not work when passing nil for uncompressedSize. This is ok in my particular use case. I don't think reporting progress is possible when the full size of the data to be compressed is not known.

Thanks for the simple library! Allows us to move off of the aging (and full of warnings/deprecations) minizip library.

@ps2
Copy link
Author

ps2 commented Sep 25, 2023

Let me know if there is anything I can change to make this acceptable. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant