Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add magic code for room.say() when @bot happen #440

Merged
merged 1 commit into from
Apr 28, 2017
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/room.ts
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 184,8 @@ export class Room extends EventEmitter implements Sayable {
const replyToList: Contact[] = [].concat(replyTo as any || [])

if (replyToList.length > 0) {
const mentionList = replyToList.map(c => '@' c.name()).join(' ')
const AT_SEPRATOR = String.fromCharCode(8197)
const mentionList = replyToList.map(c => '@' c.name()).join(AT_SEPRATOR)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need the space to separate the contacts?

const mentionList = replyToList.map(c => '@' c.name()).join(AT_SEPRATOR ' ')

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, we don't need, AT_SEPRATOR equals space.

wechat use special char with unicode code 8197 to indetify real@
by @JasLin

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

m.content(mentionList ' ' content)
} else {
m.content(content)
Expand Down