Limit the size of the sending file #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling 389af62 on mukaiu:limit_file_size into ** on Chatie:master**. |
huan
requested changes
Mar 30, 2017
src/puppet-web/puppet-web.ts
Outdated
| @@ -353,6 353,10 @@ export class PuppetWeb extends Puppet { | |||
| })) | |||
| }) | |||
|
|
|||
| let fileMaxSize = 20 * 1024 * 1024 | |||
There was a problem hiding this comment.
- Should be const instead of let.
- Could you link to the size limit code line in wxwebapp(we have a track tool named webwxapp-tracker
)? So we could track it in the future.
src/puppet-web/puppet-web.ts
Outdated
| @@ -353,6 353,10 @@ export class PuppetWeb extends Puppet { | |||
| })) | |||
| }) | |||
|
|
|||
| let fileMaxSize = 20 * 1024 * 1024 | |||
| if (buffer.length > fileMaxSize) | |||
| throw new Error('Maximum file size 20M') | |||
There was a problem hiding this comment.
20M should be calculated here instead of hard coded.
|
Changes Unknown when pulling 0f74cbe on mukaiu:limit_file_size into ** on Chatie:master**. |
1 similar comment
|
Changes Unknown when pulling 0f74cbe on mukaiu:limit_file_size into ** on Chatie:master**. |
huan
requested changes
Mar 31, 2017
src/puppet-web/puppet-web.ts
Outdated
| @@ -353,6 353,12 @@ export class PuppetWeb extends Puppet { | |||
| })) | |||
| }) | |||
|
|
|||
| // Sending video files is not allowed to exceed 20MB | |||
| // https://github.com/Chatie/webwx-app-tracker/blob/master/formatted/webwxApp.js#L1115 | |||
There was a problem hiding this comment.
Please use the link with a specific commit hash number instead of the latest, because what we want to track is a specific version.
src/puppet-web/puppet-web.ts
Outdated
| // https://github.com/Chatie/webwx-app-tracker/blob/master/formatted/webwxApp.js#L1115 | ||
| const videoMaxSize = 20 * 1024 * 1024 | ||
| if (mediatype === 'video' && buffer.length > videoMaxSize) | ||
| throw new Error('Sending video files is not allowed to exceed 20MB') |
There was a problem hiding this comment.
throw new Error('Sending video files is not allowed to exceed ' videoMaxSize/1024/1024 'MB')
There was a problem hiding this comment.
using
`Sending video files is not allowed to exceed ${videoMaxSize/1024/1024}MB`
|
My code details need to be optimized😄😄😄 |
|
Great, thanks! |
huan
approved these changes
Mar 31, 2017
huan
pushed a commit
that referenced
this pull request
Mar 31, 2017
* fix Upcase * use .alias() instead of .remark() contact.remark() should be deprecated * fix Upcase * use .alias() instead of .remark() contact.remark() should be deprecated * fix the embeded doc for .alias() * fix trailing whitespace * Limit the size of the sending file (#376) * Limit the size of the sending file * limit vedio size * add remark * tslint * Optimize videoMaxSize limit * tslint * fix Upcase * use .alias() instead of .remark() contact.remark() should be deprecated * fix the embeded doc for .alias() * fix trailing whitespace * remove unnecessary comments in the exmaple code * better example code * Set / Get / Delete => SET / GET /DELETE * better delete alias example * Revert "Limit the size of the sending file (#376)" This reverts commit a59984e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wechat web limits the file size to 20M