Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Friend search #1895

Merged
merged 26 commits into from
Jan 15, 2020
Merged

Friend search #1895

merged 26 commits into from
Jan 15, 2020

Conversation

su-chang
Copy link
Member

I'm submitting a...

[ ] Bug Fix
[x] Feature
[ ] Other (Refactoring, Added tests, Documentation, ...)

Checklist

  • Commit Messages follow the Conventional Commits pattern
    • A feature commit message is prefixed "feat:"
    • A bugfix commit message is prefixed "fix:"
  • Tests for the changes have been added

Description

please describe the changes that you are making

for features, please describe how to use the new feature

please include a reference to an existing issue, if applicable

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

@su-chang
Copy link
Member Author

Related issue: #1892

@huan huan requested review from creatorkuang and windmemory and removed request for creatorkuang January 6, 2020 14:54
windmemory
windmemory requested changes Jan 6, 2020
View reviewed changes
src/user/friendship.ts Outdated Show resolved Hide resolved
src/user/friendship.ts Outdated Show resolved Hide resolved
windmemory
windmemory previously approved these changes Jan 7, 2020
View reviewed changes
windmemory
windmemory previously approved these changes Jan 7, 2020
View reviewed changes
@huan huan requested a review from windmemory January 7, 2020 13:08
huan
huan approved these changes Jan 15, 2020
View reviewed changes
Copy link
Member

@huan huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have modified this PR to follow my design.

Please let me know if you have any question.

@huan huan merged commit b46445b into wechaty:master Jan 15, 2020
@huan
Copy link
Member

huan commented Jan 15, 2020

This feature will be available from v0.29.40 or later.

Thank you @su-chang @windmemory for adding this feature to Wechaty!

@huan huan mentioned this pull request Jan 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huan huan huan approved these changes

@windmemory windmemory Awaiting requested review from windmemory

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@su-chang @huan @windmemory