Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To Disable WebDriverJS promise manager for Selenium v3.0 #72

Closed
huan opened this issue Nov 4, 2016 · 1 comment
Closed

To Disable WebDriverJS promise manager for Selenium v3.0 #72

huan opened this issue Nov 4, 2016 · 1 comment

Comments

@huan
Copy link
Member

huan commented Nov 4, 2016

Selenium WebDriver 3.0 introduced a new environment variable named SELENIUM_PROMISE_MANAGER to disable the ControlFlow inside selenium, which is not necessary when we use async/await: SeleniumHQ/selenium#2969

This is according to an old bug which related with selenium webdriver 2.x non-standard promise, submit by me: SeleniumHQ/selenium#2233

And here's another issue related to this: angular/jasminewd#59

So what we need to do is to test Wechaty PuppetWeb with SELENIUM_PROMISE_MANAGER set to 0

I hope this can make some strange bug disappear, for example, sometimes BrowserDriver getChromeDriver will hang when calling selenium in unit tests in the last serval months, which will cause the unit test fail with no reason.

@huan
Copy link
Member Author

huan commented Nov 7, 2016

nothing significantly changed after did this...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant