Fix lint #5
Fix lint #5
Conversation
src/puppet-lark.ts
Outdated
| @@ -242,22 262,26 @@ class PuppetLark extends Puppet { | |||
| contactAlias(contactId: string): Promise<string> | |||
| contactAlias(contactId: string, alias: string): Promise<void> | |||
| async contactAlias (contactId: any, alias?: any): Promise<string | void> { | |||
| console.info(contactId) | |||
There was a problem hiding this comment.
We should use log.verbose() and follow the format of other log messages to log debug info.
src/puppet-lark.ts
Outdated
| console.info('ERROR: There is no alias in lark.') | ||
| } | ||
|
|
||
| contactAvatar(contactId: string): Promise<FileBox> | ||
| contactAvatar(contactId: string, file: FileBox): Promise<void> | ||
| async contactAvatar (contactId: any, file?: any): Promise<FileBox | void> { | ||
| console.info(contactId) | ||
| console.info(file) |
There was a problem hiding this comment.
use log.verbose() & log.silly().
verbose for the first message in your method, normally it will log the function basic information.
other log messages should use log.silly()
src/puppet-lark.ts
Outdated
| @@ -272,22 296,28 @@ class PuppetLark extends Puppet { | |||
| } | |||
|
|
|||
| protected contactRawPayload (contactId: string): Promise<any> { | |||
| console.info(contactId) | |||
There was a problem hiding this comment.
change to:
log.verbose('PuppetLark', 'contactRawPayload(%s)', contactId)
I've modified the code, please check it again. Thanks！ |
|
This is a huge PR and it fixed most of the problems from the code base earlier. Now all linting have been passed and it's ready for us to move forward. Thank you @Roxanne718 for your effort to improve the quality of our code base, appreciate it! |
#4