Fix Windows CI build #785
Merged
Fix Windows CI build #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This somehow fixes the CI job apparently succeeding even though the script returned non-zero.
Keeps the shell cleaner by discarding environment variables when the script exits.
It is "exit /b", not "exit \b". Fixes the command terminating the whole terminal.
SteffenL
force-pushed
the
up/fix-go-ci-build
branch
from
300e4dd
to
c90a326
Compare
SteffenL
added a commit
to SteffenL/webview
that referenced
this pull request
Jun 28, 2022
GitHub Actions somehow does not have this directory in the PATH environment variable. This fix allows programs built with MinGW-w64 to find runtime libraries and is more explicit about which version of MinGW-w64 will be used for compilation.
justjosias
approved these changes
Jul 3, 2022
SteffenL
added
scope: ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Windows CI build has been broken since #773 and it has not been detected because the build has been reported as successful despite the build script exiting with a non-zero exit code.
Builds have worked in my local environment with Go 1.18 which has a fix for an issue with quotes/spaces in environment variables (e.g.
CGO_LDFLAGS), while GitHub Actions has Go 1.17.11 currently without the fix for that issue.I have fixed a few other things as well in the build script for Windows.