More functionality #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
November 3, 2017 15:32
# Conflicts: # dist/build.js.map
removeAll method added README.MD improved
websmurf
reviewed
Nov 5, 2017
src/Notify.vue
Outdated
| <transition-group name="notify" tag="div" @enter="slideDown" @leave="slideUp"> | ||
| <div v-for="(item, key) in items" :key="key" class="notify-item"> | ||
| <div :class="item.options.itemClass"> | ||
| <span :class="item.options.iconClass" v-if="item.options.iconClass"></span> {{ item.text }}</div> | ||
| <button v-if="item.options.closeButton === 'bulma'" class="delete" @click="removeItem(key)"></button> |
There was a problem hiding this comment.
I do not like the strict tie-in to bulma (or bootstrap for that matter), isn't there another solution that will give the same results?
There was a problem hiding this comment.
Maybe something like that:
<button v-if="item.options.closeButtonClass" :class="item.options.closeButtonClass" @click="removeItem(key)" type="button" aria-label="Close"></button>
<span aria-hidden="true">×</span>
</button>
If closeButtonClass option === false (default false) - there is no close button
Would this be good?
There was a problem hiding this comment.
Jup, that would be a lot better :-)
|
Hi Adam, please review my PR. |
websmurf
approved these changes
Nov 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New options:
New methods:
Also some CSS fixes (margin between notifications) and README.MD improvement