-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to easily update component authoring behaviour? #125
Comments
We are working on the documentation related to extending the page editor. It should be ready in a few days. |
@paweljozwicki will you cover how to extend Dialog fields as well? I am trying to add isDisabled to Text and other form components. |
@paweljozwicki I am trying to add a simple Link component to dialog, but it does not seem to work. I have created
and
and then added it to my dialog
|
Anyways I've figured out how to do this :D |
@paweljozwicki Have you overwritten window.open in React? I am trying to do window.open with target "_blank" and it opens in same tab 😢 |
We didn't overwrite window.open. this.openLink = () => {
const { value } = this.props;
window.open(value, '_blank');
}; and it works fine on Chrome (Version 109.0.5414.119), Firefox (Version 109.0.1), and Safari (Version 15.6.1) |
I was on brave. I've changed the button to |
@paweljozwicki I am still keen to see how to add a button to the edit controls of a component. :D |
We remember that, but still working on documentation. If it's urgent then you can use a WebAction (here is an example) but we would like to introduce new solution and not sure if WebActions will be supported in the future. |
Is your feature request related to a problem? Please describe.
Some components need to have new buttons added to the edit toolbar and have ability to refresh page or component when interacting within edit ui.
Need to be able to add new items specifying icon, text and URL to open.
How to do this easily?
Describe the solution you'd like
Would be great to specify this at component level in a dedicated file same as dialog config
component/edit/content.json
. Similar functionality exist in AEM eg cq:listeners and cq:actionConfigs. You can see possible dialog configs here https://experienceleague.adobe.com/docs/experience-manager-65/developing/components/components-basics.html?lang=en#cq-actionconfigs-classic-ui-onlyImplementing these will allow more separation of concern so that we don't have to override everything.
Describe alternatives you've considered
Overriding existing JS but its source but that is yuck and just going to be messy long term.
The text was updated successfully, but these errors were encountered: