Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add some es-modules concatenation cases #566

Merged
merged 1 commit into from
Aug 13, 2020
Merged

test: add some es-modules concatenation cases #566

merged 1 commit into from
Aug 13, 2020

Conversation

irudoy
Copy link
Contributor

@irudoy irudoy commented Aug 13, 2020

closes #357

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Breaking Changes

Additional Info

@irudoy irudoy mentioned this pull request Aug 13, 2020
6 tasks
@codecov
Copy link

codecov bot commented Aug 13, 2020

Codecov Report

Merging #566 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #566    /-   ##
=======================================
  Coverage   88.55%   88.55%           
=======================================
  Files           5        5           
  Lines         428      428           
  Branches       96       96           
=======================================
  Hits          379      379           
  Misses         47       47           
  Partials        2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6e07bb...a8fcf52. Read the comment docs.

@irudoy irudoy requested a review from alexander-akait August 13, 2020 15:07
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Good job!

@alexander-akait alexander-akait merged commit 25b0ecd into webpack-contrib:master Aug 13, 2020
@irudoy irudoy deleted the test-empty-modules branch August 13, 2020 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Optimization request] Remove empty "modules"
3 participants