Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(package): update peerDependencies (webpack v3.0.0) #200

Merged
merged 1 commit into from
Jun 20, 2017
Merged

chore(package): update peerDependencies (webpack v3.0.0) #200

merged 1 commit into from
Jun 20, 2017

Conversation

michael-ciniawsky
Copy link
Member

What kind of change does this PR introduce?

  • Chore

Does this PR introduce a breaking change?

  • No

@michael-ciniawsky
Copy link
Member Author

Fixes #199

@shellscape shellscape merged commit a9e83b4 into webpack:master Jun 20, 2017
@shellscape shellscape mentioned this pull request Jun 20, 2017
2 tasks
@michael-ciniawsky michael-ciniawsky deleted the chore branch June 20, 2017 12:54
@michael-ciniawsky
Copy link
Member Author

@shellscape Thx

@SimenB
Copy link

SimenB commented Jun 20, 2017

Can this get a release as well?

@shellscape
Copy link
Contributor

@SimenB we'll release this soon I'm sure. However, it's not critical. The peerDep will only display a warning and it doesn't impact your ability being able to use webpack@3.

@kesne
Copy link

kesne commented Jun 20, 2017

@shellscape That's true, but I'm pretty sure you can't shrinkwrap your apps with an invalid peer dependency, making it hard to actually use webpack 3 until all of the peerDependencies requirements are met.

@shellscape
Copy link
Contributor

@kesne indeed, it looks like that's still an issue: npm/npm#12909, and the NPM housecleaning has prematurely closed the issue. Would be wise to open that up as an issue at https://package.community/. Yarn apparently does not have the same limitation.

@ankurk91
Copy link

@shellscape

we'll release this soon I'm sure. However, it's not critical. The peerDep will only display a warning and it doesn't impact your ability being able to use webpack@3.

Actually it impacts, (npm v4.6.1)
npm shrinkwrap
is failing because of peerDependency

npm ERR! peer invalid: webpack@1 || ^2.1.0-beta || ^2.2.0-rc.0, required by [email protected]

@shellscape
Copy link
Contributor

folks, I'd like to ask for patience at this time. please hold off on 1 comments until we get the release out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants