Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(templates): Branding guide violation fix #1226

Merged
merged 3 commits into from
Feb 16, 2020
Merged

docs(templates): Branding guide violation fix #1226

merged 3 commits into from
Feb 16, 2020

Conversation

wizardofhogwarts
Copy link
Contributor

No description provided.

rishabh3112
rishabh3112 requested changes Feb 16, 2020
View reviewed changes
Copy link
Member

@rishabh3112 rishabh3112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @wizardofhogwarts!
Please change title such that it suggests branding guide violation.
Also left a suggestion.

packages/generators/templates/template.html Outdated Show resolved Hide resolved
@wizardofhogwarts
Copy link
Contributor Author

Hi @wizardofhogwarts!
Please change title such that it suggests branding guide violation.
Also left a suggestion.

@rishabh3112 Can you please suggest a title

@webpack-bot
Copy link

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@webpack-bot
Copy link

@wizardofhogwarts Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@rishabh3112 Please review the new changes.

anshumanv
anshumanv reviewed Feb 16, 2020
View reviewed changes
Copy link
Member

@anshumanv anshumanv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commitlint is failing, can you amend your commit or commit using npm run commit?

@wizardofhogwarts wizardofhogwarts changed the title docs(templates): Grammatical fixes docs(templates): Branding guide violation fix Feb 16, 2020
@wizardofhogwarts
Copy link
Contributor Author

Hi @wizardofhogwarts!
Please change title such that it suggests branding guide violation.
Also left a suggestion.

@rishabh3112 Can you please suggest a title

@rishabh3112 I have changed the title

@wizardofhogwarts @rishabh3112
chore: remove the from title
6d45310 
Co-Authored-By: Rishabh Chawla <[email protected]>
@webpack webpack deleted a comment Feb 16, 2020
@webpack webpack deleted a comment Feb 16, 2020
@ematipico ematipico merged commit ab910df into webpack:master Feb 16, 2020
@wizardofhogwarts wizardofhogwarts deleted the patch-1 branch March 22, 2020 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesgeorge007 jamesgeorge007 jamesgeorge007 approved these changes

@anshumanv anshumanv anshumanv approved these changes

@rishabh3112 rishabh3112 rishabh3112 approved these changes

@ematipico ematipico ematipico approved these changes

Assignees
No one assigned
Labels
PR: CI-ok PR: reviewed-approved PR: small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@wizardofhogwarts @webpack-bot @ematipico @rishabh3112 @anshumanv @jamesgeorge007