fix: make bigint and globalThis optimistic #18484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For maintainers only:
|
|
I'm not quite sure why optimistic wasn't added initially; I guess it was because browsers or node only supported these features in relatively newer versions at the time, but now they are generally supported, so LGTM. |
|
you need to update snapshots |
alexander-akait
force-pushed
the
fix-optimistic
branch
from
3334b39
to
964b9aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
Exiting
Does this PR introduce a breaking change?
And yes and no, but it is more about bug
What needs to be documented once your changes are merged?
Yes
/cc @vankop @ahabhgk
What do you think? We already use the same logic for
const/arrow function/for-of