Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin for finding circular dependencies #7962

Open
danburzo opened this issue Aug 28, 2018 · 5 comments
Open

Plugin for finding circular dependencies #7962

danburzo opened this issue Aug 28, 2018 · 5 comments

Comments

@danburzo
Copy link

Feature request

Logging this issue as per @evilebottnawi's request here

A plugin that can identify circular dependencies in modules, similar to aackerman/circular-dependency-plugin, would work well in core Webpack.

What is the expected behavior?

Either enabled by default for mode: development, or registered by the user manually in the plugins array.

What is motivation or use case for adding/changing the behavior?

We've recently upgraded to Webpack 4, set mode: production, and modules: false in Babel, and we've been pleasantly surprised by ModuleConcatenationPlugin and the tree-shaking features. However, we've had a few instances where circular dependencies would break at runtime, and this plugin helped us quicky identify where these were.

How should this be implemented in your opinion?

as webpack.CircularDependenciesPlugin with the ability to include/exclude module patterns, as some circular dependencies are not avoidable.

Are you willing to work on this yourself?

I can help test it, but I don't have enough experience with the Webpack codebase.

@sokra
Copy link
Member

sokra commented Aug 28, 2018

There already exists an plugin. Why should this be moved into the core?

@danburzo
Copy link
Author

I'm... not sure? 😅 Mainly following @evilebottnawi's suggestion on the PR for webpack-contrib/awesome-webpack, maybe they can chip in?

@alexander-akait
Copy link
Member

@sokra for better DX?

@webpack-bot
Copy link
Contributor

This issue had no activity for at least half a year.

It's subject to automatic issue closing if there is no activity in the next 15 days.

@webpack-bot
Copy link
Contributor

Issue was closed because of inactivity.

If you think this is still a valid issue, please file a new issue with additional information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants