Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: copiable export info #7390

Merged
merged 2 commits into from
Jul 31, 2024
Merged

refactor: copiable export info #7390

merged 2 commits into from
Jul 31, 2024

Conversation

ahabhgk
Copy link
Collaborator

@ahabhgk ahabhgk commented Jul 31, 2024

Summary

  • move method on ExportInfo into ExportInfoId, the second param is always &ModuleGraph or &mut ModuleGraph, which is kind of a 'token' implies this method is mutable or immutable.
  • since now every method need get ExportInfo on ModuleGraph, so use UkeyMap to optimize this.
  • rename ExportInfoId to ExportInfo, ExportInfo to ExportInfoData, in most of cases you should only care aboue ExportInfo instead of ExportInfoData.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Jul 31, 2024

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 8c2b932
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66aa31ded7d15700083f13fd

@ahabhgk ahabhgk enabled auto-merge (squash) July 31, 2024 12:45
@ahabhgk ahabhgk requested review from LingyuCoder and JSerFeng and removed request for jerrykingxyz July 31, 2024 12:47
@ahabhgk ahabhgk merged commit 0f5d217 into main Jul 31, 2024
28 checks passed
@ahabhgk ahabhgk deleted the refactor-export-info branch July 31, 2024 13:01
@chenjiahan chenjiahan mentioned this pull request Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants