Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lightningcss-loader targets array not work as expected #7331

Merged
merged 4 commits into from
Jul 28, 2024

Conversation

chenjiahan
Copy link
Member

Summary

Fix lightningcss-loader targets array not working as expected.

When targets is string, it is converted from browserslist query to browser array, but when target is array, the conversion process is missing.

https://lightningcss.dev/transpilation.html

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@chenjiahan chenjiahan requested a review from JSerFeng July 27, 2024 13:40
@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Jul 27, 2024
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Jul 27, 2024
@JSerFeng JSerFeng merged commit c507fe6 into main Jul 28, 2024
28 checks passed
@JSerFeng JSerFeng deleted the lightningcss_loader_targets_0727 branch July 28, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants