Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(plugin/css-extract): use typescript for css-extract-hmr #7245

Merged
merged 16 commits into from
Jul 24, 2024
Merged

refactor(plugin/css-extract): use typescript for css-extract-hmr #7245

merged 16 commits into from
Jul 24, 2024

Conversation

wxiaoyun
Copy link
Contributor

Summary

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify Netlify
Copy link

netlify bot commented Jul 21, 2024 •
edited
Loading

✅ Deploy Preview for rspack ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit fab4da0
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/669e4a26e1c24e00087bc6fa
😎 Deploy Preview https://deploy-preview-7245--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@wxiaoyun wxiaoyun changed the title Refactor/css extract hmr refactor: css extract hmr Jul 21, 2024
@SoonIter SoonIter self-assigned this Jul 21, 2024
@wxiaoyun
Copy link
Contributor Author

wxiaoyun commented Jul 21, 2024 •
edited
Loading

Strange... the hotSnapshot test passes locally. And running npm run test:hot -- -u in rspack/packages/rspack-test-tools doesnt modify anything. I am clueless

image

@wxiaoyun
Copy link
Contributor Author

wxiaoyun commented Jul 21, 2024 •
edited
Loading

My bad 💀, I had to rebuild the packages

@SoonIter SoonIter changed the title refactor: css extract hmr refactor(typescript): css extract hmr Jul 21, 2024
@wxiaoyun wxiaoyun requested a review from SoonIter July 22, 2024 12:35
@h-a-n-a h-a-n-a changed the title refactor(typescript): css extract hmr refactor(plugin/css-extract): css extract hmr Jul 23, 2024
@SoonIter
Copy link
Member

I made some modifications and passed the CI, and you can review the code
@JSerFeng could you take a look?

@JSerFeng JSerFeng changed the title refactor(plugin/css-extract): css extract hmr refactor(plugin/css-extract): use typescript for css-extract-hmr Jul 24, 2024
@JSerFeng
Copy link
Collaborator

WIll this cause problems for you ? Runtime api has small changes, and become esm @colinaaa

@colinaaa
Copy link
Contributor

WIll this cause problems for you ? Runtime api has small changes, and become esm @colinaaa

Thanks for letting me know. This PR LGTM. We are using our own runtime for CSS extract.

@SoonIter SoonIter merged commit fc0e208 into web-infra-dev:main Jul 24, 2024
27 checks passed
@colinaaa
Copy link
Contributor

You may also want to port this: webpack-contrib/mini-css-extract-plugin#1090 😄

@SoonIter SoonIter mentioned this pull request Jul 25, 2024
Closed
@chenjiahan chenjiahan mentioned this pull request Jul 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SoonIter SoonIter SoonIter approved these changes

@h-a-n-a h-a-n-a Awaiting requested review from h-a-n-a

@JSerFeng JSerFeng Awaiting requested review from JSerFeng

Assignees

@SoonIter SoonIter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wxiaoyun @SoonIter @JSerFeng @colinaaa