Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: invalid "javascript/auto" rule.type in getRawGeneratorOptions #7164

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

9aoy
Copy link
Collaborator

@9aoy 9aoy commented Jul 15, 2024

Summary

fix invalid "javascript/auto" rule.type in getRawGeneratorOptions:

image

No generator options are supported for module type javascript/auto / javascript / javascript/dynamic / javascript/esm, it should be ignored instead of throw an error.

#6873 (comment)

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@9aoy 9aoy requested a review from ahabhgk July 15, 2024 11:19
@github-actions github-actions bot added release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack. labels Jul 15, 2024
Copy link

netlify bot commented Jul 15, 2024

Deploy Preview for rspack ready!

Name Link
🔨 Latest commit deab015
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/669505cf2e0c7e00080cb353
😎 Deploy Preview https://deploy-preview-7164--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ahabhgk ahabhgk merged commit d1d414c into main Jul 15, 2024
34 checks passed
@ahabhgk ahabhgk deleted the ignore-js-generator-options branch July 15, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants