Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove ErrorHelpers.js ts-expect-error #7136

Merged
merged 5 commits into from
Jul 12, 2024
Merged

refactor: remove ErrorHelpers.js ts-expect-error #7136

merged 5 commits into from
Jul 12, 2024
72 −78

Conversation

SoonIter
Copy link
Member

Summary

.js -> .ts

#7132
#4640

@netlify Netlify
Copy link

netlify bot commented Jul 12, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit dd53d9d
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66911de282d26d00081c612a

@SoonIter SoonIter requested a review from chenjiahan July 12, 2024 11:13
chenjiahan
chenjiahan approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chenjiahan chenjiahan merged commit 070a6c5 into web-infra-dev:main Jul 12, 2024
29 checks passed
@SoonIter SoonIter mentioned this pull request Jul 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenjiahan chenjiahan chenjiahan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SoonIter @chenjiahan