Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(deps)!: updatewebpack-dev-server to v5 and no longer lock the versions #7130

Merged
merged 6 commits into from
Jul 23, 2024
Merged

feat(deps)!: updatewebpack-dev-server to v5 and no longer lock the versions #7130

merged 6 commits into from
Jul 23, 2024

Conversation

SoonIter
Copy link
Member

@SoonIter SoonIter commented Jul 12, 2024 •
edited
Loading

Summary

  1. update webpack-dev-server ws and related deps version
  2. release the semver restrictions ^x.x.x
  3. unify the version of express and @types/ws

#7030

https://github.com/webpack/webpack-dev-server/blob/master/migration-v5.md

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify Netlify
Copy link

netlify bot commented Jul 12, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 683c621
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/669f66268b1ae30008fc80ca

@SoonIter
Copy link
Member Author

😢 Type is failed because of phantom dependence

img_v3_02cn_4326167b-8eb4-45d8-a3ce-1cda6f73da4g

@SoonIter SoonIter mentioned this pull request Jul 15, 2024
Open
@SoonIter SoonIter force-pushed the update-ws branch 2 times, most recently from ac4af4c to 96f4d22 Compare July 16, 2024 08:13
@SoonIter SoonIter changed the title chore(update): update version of ws and webpack-dev-server chore(update)!: update version of ws and webpack-dev-server Jul 16, 2024
@SoonIter SoonIter changed the title chore(update)!: update version of ws and webpack-dev-server chore(deps)!: update version of ws and webpack-dev-server Jul 16, 2024
@SoonIter SoonIter force-pushed the update-ws branch 3 times, most recently from b856728 to e316200 Compare July 21, 2024 15:50
@SoonIter
Copy link
Member Author

SoonIter commented Jul 23, 2024 •
edited
Loading

I'll document this breaking change later
aligned with webpack document
https://github.com/webpack/webpack-dev-server/blob/master/migration-v5.md

webpack/webpack.js.org#7144

image

@SoonIter SoonIter changed the title chore(deps)!: update version of ws and webpack-dev-server chore(deps)!: update major version of webpack-dev-server and release the semver restriction of @rspack/devServer Jul 23, 2024
@SoonIter SoonIter requested a review from chenjiahan July 23, 2024 07:54
@SoonIter SoonIter changed the title chore(deps)!: update major version of webpack-dev-server and release the semver restriction of @rspack/devServer chore(deps)!: update major version of webpack-dev-server and release the semver restriction of @rspack/devServer Jul 23, 2024
@xc2 xc2 mentioned this pull request Jul 23, 2024
Merged
2 tasks
@chenjiahan chenjiahan changed the title chore(deps)!: update major version of webpack-dev-server and release the semver restriction of @rspack/devServer feat(deps)!: updatewebpack-dev-server to v5 and no longer lock the versions Jul 23, 2024
@github-actions github-actions bot added the release: feature release: feature related release(mr only) label Jul 23, 2024
@chenjiahan chenjiahan enabled auto-merge (squash) July 23, 2024 08:33
@chenjiahan chenjiahan merged commit 663bf12 into web-infra-dev:main Jul 23, 2024
29 checks passed
@chenjiahan
Copy link
Member

Added breaking change label, as this should be considered as a breaking change.

@chenjiahan chenjiahan added release: breaking change release: breaking change related release(mr only) and removed breaking change labels Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenjiahan chenjiahan chenjiahan approved these changes

Assignees
No one assigned
Labels
release: breaking change release: breaking change related release(mr only) release: feature release: feature related release(mr only)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SoonIter @chenjiahan