Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: reduce get_scheme allocation #7109

Merged
merged 3 commits into from
Jul 10, 2024
Merged

perf: reduce get_scheme allocation #7109

merged 3 commits into from
Jul 10, 2024
13 −10

Conversation

h-a-n-a
Copy link
Collaborator

@h-a-n-a h-a-n-a commented Jul 10, 2024 •
edited
Loading

Summary

Do not alloc on get_scheme.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added team The issue/pr is created by the member of Rspack. release: performance release: performance related release(mr only) labels Jul 10, 2024
@netlify Netlify
Copy link

netlify bot commented Jul 10, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 6b67100
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/668e88f1a8f8aa000781577b

@h-a-n-a h-a-n-a enabled auto-merge (squash) July 10, 2024 13:21
@h-a-n-a h-a-n-a merged commit 78c1194 into main Jul 10, 2024
29 checks passed
@h-a-n-a h-a-n-a deleted the reduce-alloc branch July 10, 2024 15:51
@chenjiahan chenjiahan mentioned this pull request Jul 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahabhgk ahabhgk ahabhgk approved these changes

Assignees

@h-a-n-a h-a-n-a

Labels
release: performance release: performance related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@h-a-n-a @ahabhgk