Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: remove unneeded string clone #7104

Merged
merged 1 commit into from
Jul 10, 2024
Merged

perf: remove unneeded string clone #7104

merged 1 commit into from
Jul 10, 2024
141 −150

Conversation

JSerFeng
Copy link
Collaborator

@JSerFeng JSerFeng commented Jul 10, 2024 •
edited
Loading

Summary

Remove some unneeded string allocation.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: performance release: performance related release(mr only) label Jul 10, 2024
@JSerFeng
Copy link
Collaborator Author

!bench

@netlify Netlify
Copy link

netlify bot commented Jul 10, 2024 •
edited
Loading

✅ Deploy Preview for rspack ready!

Name Link
🔨 Latest commit d13305c
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/668e6d3b215cdf00075de4b6
😎 Deploy Preview https://deploy-preview-7104--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rspack-bot
Copy link

rspack-bot commented Jul 10, 2024 •
edited
Loading

📝 Benchmark detail: Open

Name Base (2024-07-10 7d3eabb) Current Change
10000_development-mode exec 2.19 s ± 24 ms 2.16 s ± 26 ms -1.15 %
10000_development-mode_hmr exec 692 ms ± 5.3 ms 689 ms ± 7 ms -0.35 %
10000_production-mode exec 2.84 s ± 18 ms 2.77 s ± 21 ms -2.18 %
arco-pro_development-mode exec 1.9 s ± 85 ms 1.88 s ± 65 ms -1.25 %
arco-pro_development-mode_hmr exec 434 ms ± 2.3 ms 433 ms ± 1.2 ms -0.18 %
arco-pro_production-mode exec 3.41 s ± 86 ms 3.44 s ± 85 ms 0.89 %
threejs_development-mode_10x exec 1.59 s ± 10 ms 1.57 s ± 18 ms -1.48 %
threejs_development-mode_10x_hmr exec 799 ms ± 11 ms 794 ms ± 5.3 ms -0.54 %
threejs_production-mode_10x exec 5.61 s ± 40 ms 5.51 s ± 23 ms -1.72 %

@JSerFeng JSerFeng marked this pull request as ready for review July 10, 2024 11:32
@JSerFeng JSerFeng merged commit 5dc33d7 into main Jul 10, 2024
30 checks passed
@JSerFeng JSerFeng deleted the perf/reduce-string-clone branch July 10, 2024 11:39
@chenjiahan
Copy link
Member

Please add some descriptions 😄

image

@chenjiahan chenjiahan mentioned this pull request Jul 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahabhgk ahabhgk ahabhgk approved these changes

@jerrykingxyz jerrykingxyz Awaiting requested review from jerrykingxyz jerrykingxyz is a code owner

Assignees

@JSerFeng JSerFeng

Labels
release: performance release: performance related release(mr only)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JSerFeng @rspack-bot @chenjiahan @ahabhgk