Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing code for compatibility plugin #7079

Merged

Conversation

CPunisher
Copy link
Contributor

Summary

fix #6909
related webpack code: https://github.com/webpack/webpack/blob/8241da7f1e75c5581ba535d127fa66aeb9eb2ac8/lib/CompatibilityPlugin.js#L92

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Jul 8, 2024
Copy link

netlify bot commented Jul 8, 2024

Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit d785e11
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/668bd969f2f8a20008a81a65

@h-a-n-a
Copy link
Collaborator

h-a-n-a commented Jul 8, 2024

Would you please add a test?

@CPunisher CPunisher force-pushed the fix/compatibility-plugin-missing branch from 931346e to 08aa705 Compare July 8, 2024 12:08
Copy link
Collaborator

@h-a-n-a h-a-n-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@h-a-n-a h-a-n-a merged commit 81b26f8 into web-infra-dev:main Jul 9, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: compatibility plugin not works well
2 participants