-
-
Notifications
You must be signed in to change notification settings - Fork 571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Module Federation, part 3, ProvideSharedPlugin #4778
Merged
ahabhgk
merged 3 commits into
main
from
11-24-feat_Module_Federation_part_3_ProvideSharedPlugin
Nov 27, 2023
Merged
feat: Module Federation, part 3, ProvideSharedPlugin #4778
ahabhgk
merged 3 commits into
main
from
11-24-feat_Module_Federation_part_3_ProvideSharedPlugin
Nov 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahabhgk
requested review from
jerrykingxyz,
IWANABETHATGUY and
ScriptedAlchemy
November 24, 2023 13:47
2 tasks
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
2 tasks
github-actions
bot
added
the
team
The issue/pr is created by the member of Rspack.
label
Nov 24, 2023
github-actions
bot
added
the
release: feature
release: feature related release(mr only)
label
Nov 24, 2023
Base automatically changed from
11-21-feat_Module_Federation_part_2_ContainerReferencePlugin
to
main
November 24, 2023 14:04
ahabhgk
force-pushed
the
11-24-feat_Module_Federation_part_3_ProvideSharedPlugin
branch
from
November 24, 2023 14:32
baaa670
to
1d5336d
Compare
Test Compatibility Diff
Unpassed tests
|
2 tasks
JSerFeng
approved these changes
Nov 27, 2023
ahabhgk
deleted the
11-24-feat_Module_Federation_part_3_ProvideSharedPlugin
branch
November 27, 2023 07:00
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release: feature
release: feature related release(mr only)
team
The issue/pr is created by the member of Rspack.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
Require Documentation?