Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(runtime): alignment of commonjs exports dependency #4572

Merged
merged 9 commits into from
Nov 9, 2023
Merged

feat(runtime): alignment of commonjs exports dependency #4572

merged 9 commits into from
Nov 9, 2023

Conversation

LingyuCoder
Copy link
Collaborator

Summary

Alignment of commonjs exports dependency,

  • Currently commonjs tree shaking does not implemented in rspack, so used name will always return itself
  • This is a pre-task for alignment of module level runtime requirements and commonjs tree shaking
  • Runtime requirements will also affected the result of render_module

Test Plan

  • Test cases have been exists under test/cases/mjs

Require Documentation?

  • No

@github-actions github-actions bot added the release: feature release: feature related release(mr only) label Nov 8, 2023
@LingyuCoder LingyuCoder added the same as webpack The behavior is the same as Webpack label Nov 8, 2023
@LingyuCoder LingyuCoder added this pull request to the merge queue Nov 9, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 9, 2023
@LingyuCoder LingyuCoder added this pull request to the merge queue Nov 9, 2023
Merged via the queue into main with commit 89eac9d Nov 9, 2023
15 checks passed
@LingyuCoder LingyuCoder deleted the feat/commonjs-exports-dependency branch November 9, 2023 05:40
@LingyuCoder LingyuCoder self-assigned this Nov 10, 2023
JSerFeng added a commit that referenced this pull request Nov 16, 2023
@JSerFeng
Revert "feat(runtime): alignment of commonjs exports dependency (#4572)"
2e891df 
This reverts commit 89eac9d.
@JSerFeng JSerFeng mentioned this pull request Nov 16, 2023
Merged
github-merge-queue bot pushed a commit that referenced this pull request Nov 17, 2023
@JSerFeng
fix(runtime): revert alignment of commonjs exports dependency (#4679)
3e4362d 
Revert "feat(runtime): alignment of commonjs exports dependency (#4572)"

This reverts commit 89eac9d.
@LingyuCoder LingyuCoder mentioned this pull request Nov 20, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IWANABETHATGUY IWANABETHATGUY IWANABETHATGUY approved these changes

@ahabhgk ahabhgk Awaiting requested review from ahabhgk

@JSerFeng JSerFeng Awaiting requested review from JSerFeng

@jerrykingxyz jerrykingxyz Awaiting requested review from jerrykingxyz

@ScriptedAlchemy ScriptedAlchemy Awaiting requested review from ScriptedAlchemy

@h-a-n-a h-a-n-a Awaiting requested review from h-a-n-a

Assignees

@LingyuCoder LingyuCoder

Labels
release: feature release: feature related release(mr only) same as webpack The behavior is the same as Webpack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LingyuCoder @IWANABETHATGUY