Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Rspack errors seem to not support the correct location #7327

Closed
shulaoda opened this issue Jul 27, 2024 · 1 comment · Fixed by #7328
Closed

[Bug]: Rspack errors seem to not support the correct location #7327

shulaoda opened this issue Jul 27, 2024 · 1 comment · Fixed by #7328
Labels
bug Something isn't working pr welcome

Comments

@shulaoda
Copy link
Contributor

shulaoda commented Jul 27, 2024 •
edited
Loading

Details

Related to #6051

image

Reproduce link

No response

Reproduce Steps

  1. Config rspack.config.js
  2. Import non-existent module
@shulaoda shulaoda added bug Something isn't working pending triage The issue/PR is currently untouched. labels Jul 27, 2024
@h-a-n-a
Copy link
Collaborator

h-a-n-a commented Jul 27, 2024 •
edited
Loading

This is a limitation from miette. Currently, miette's strategy is to render the first line of the code snippet.
See snapshots from the old oxc lint: https://github.com/oxc-project/oxc/blob/6e5aad26393c363e64cd3040547f3184538fa9b7/crates/oxc_linter/src/snapshots/adjacent_overload_signatures.snap. We can take this later fix as an reference to fix this issue: oxc-project/oxc#2213

@h-a-n-a h-a-n-a added pr welcome and removed pending triage The issue/PR is currently untouched. labels Jul 27, 2024
@shulaoda shulaoda mentioned this issue Jul 27, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working pr welcome
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: rspack errors don't support the correct location shulaoda/rspack
2 participants
@h-a-n-a @shulaoda