Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: migrate codebase to pure esm #7089

Closed
hardfist opened this issue Jul 9, 2024 · 2 comments
Closed

refactor: migrate codebase to pure esm #7089

hardfist opened this issue Jul 9, 2024 · 2 comments
Assignees
@SoonIter
Labels
stale team The issue/pr is created by the member of Rspack.

Comments

@hardfist
Copy link
Contributor

hardfist commented Jul 9, 2024 •
edited
Loading

we migrate lots of webpack's internal code which is commonjs format, which may cause some interop issue with rspack's esm code and is not good for treeshaking if we bundle rspack's code.
we should migrate all existing commonjs code to esm
notice that we do migrate to esm module other than strict esm module during this refactor which means we still compiles all code to commonjs

strict esm maybe supported in 2.0
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Jul 9, 2024
@stale Stale
Copy link

stale bot commented Sep 7, 2024

This issue has been automatically marked as stale because it has not had recent activity. If this issue is still affecting you, please leave any comment (for example, "bump"). We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

@stale stale bot added the stale label Sep 7, 2024
@SoonIter
Copy link
Member

SoonIter commented Sep 7, 2024

this task has been done in #7225

@SoonIter SoonIter closed this as completed Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SoonIter SoonIter

Labels
stale team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hardfist @SoonIter