Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support splitChunks.automatic_name_delimiter #4335

Closed
Tracked by #4327
JSerFeng opened this issue Oct 16, 2023 · 3 comments
Closed
Tracked by #4327

Support splitChunks.automatic_name_delimiter #4335

JSerFeng opened this issue Oct 16, 2023 · 3 comments

Comments

@JSerFeng
Copy link
Collaborator

JSerFeng commented Oct 16, 2023

should support splitChunks.automaticNameDelimiter

@JSerFeng JSerFeng self-assigned this Oct 16, 2023
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Oct 16, 2023
@JSerFeng JSerFeng added contrib: has guidance good first issue Good for newcomers p3-nice-to-have and removed team The issue/pr is created by the member of Rspack. labels Oct 16, 2023
@OceanPresentChao
Copy link
Contributor

there are rspack_plugin_split_chunks_new and rspack_plugin_split_chunks, should we support splitChunks.automatic_name_delimiter for both of them?

@hardfist
Copy link
Contributor

there are rspack_plugin_split_chunks_new and rspack_plugin_split_chunks, should we support splitChunks.automatic_name_delimiter for both of them?

just the new

@OceanPresentChao
Copy link
Contributor

there are rspack_plugin_split_chunks_new and rspack_plugin_split_chunks, should we support splitChunks.automatic_name_delimiter for both of them?

just the new

It seems that rspack names chunks through plugin named_chunk_ids_plugin, which could set delimiter only once. So shall we support setting delimiter for multiple cachegroups in rspack.config.js
for example:

module.exports = {
  //...
  optimization: {
    splitChunks: {
      automaticNameDelimiter: '~',
      cacheGroups: {
        vendor1: {
          automaticNameDelimiter: '#',
        },
        vendor2: {
          automaticNameDelimiter: '@',
        },
      },
    },
  },
};

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants