Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webpackEntryOptions magic comments #3680

Closed
Tracked by #1320
ahabhgk opened this issue Jul 3, 2023 · 8 comments
Closed
Tracked by #1320

webpackEntryOptions magic comments #3680

ahabhgk opened this issue Jul 3, 2023 · 8 comments
Labels
stale team The issue/pr is created by the member of Rspack.

Comments

@ahabhgk
Copy link
Collaborator

ahabhgk commented Jul 3, 2023 •
edited
Loading

https://github.com/webpack/webpack/blob/6be4065ade1e252c1d8dcba4af0f43e32af1bdc1/examples/worker/example.js#L83
@ahabhgk ahabhgk mentioned this issue Jul 3, 2023
Closed
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Jul 3, 2023
@birtles
Copy link

birtles commented Aug 3, 2023

I notice that linked example uses webpackEntryOptions

With webpack I've been using:

    /* webpackChunkName: 'db-worker' */
    /* webpackPrefetch: true */

and at least the webpackChunkName part seems to work.

It's possible the prefetch comment is being ignored, however.

@stale
Copy link

stale bot commented Oct 2, 2023

This issue has been automatically marked as stale because it has not had recent activity. If this issue is still affecting you, please leave any comment (for example, "bump"). We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

@stale stale bot added the stale label Oct 2, 2023
@Narretz
Copy link

Narretz commented Oct 8, 2023 •
edited
Loading

I see regex that tests for webpackChunkName

rspack/crates/rspack_plugin_javascript/src/visitors/dependency/import_scanner.rs

Line 41 in d9952e8

regex::Regex::new(r#"webpackChunkName\s*:\s*("(?P<_1>(\./)?([\w0-9_\-\[\]\(\)] /)*?[\w0-9_\-\[\]\(\)] )"|'(?P<_2>(\./)?([\w0-9_\-\[\]\(\)] /)*?[\w0-9_\-\[\]\(\)] )'|`(?P<_3>(\./)?([\w0-9_\-\[\]\(\)] /)*?[\w0-9_\-\[\]\(\)] )`)"#)
so I assume it's supported,

but not really any code specific to webpackPrefetch (only lots of tests that use webpackPrefetch)

@stale stale bot removed the stale label Oct 8, 2023
@stale Stale
Copy link

stale bot commented Dec 7, 2023

This issue has been automatically marked as stale because it has not had recent activity. If this issue is still affecting you, please leave any comment (for example, "bump"). We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

@stale stale bot added the stale label Dec 7, 2023
@Narretz
Copy link

Narretz commented Dec 7, 2023

bump

Based on my previous comment #3680 (comment), I think webpackPrefetch is still not supported.

@stale stale bot removed the stale label Dec 7, 2023
@ahabhgk
Copy link
Collaborator Author

ahabhgk commented Dec 19, 2023

webpackPrefetch and webpackPreload are supported in #5031

@stale Stale
Copy link

stale bot commented Feb 17, 2024

This issue has been automatically marked as stale because it has not had recent activity. If this issue is still affecting you, please leave any comment (for example, "bump"). We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

@stale stale bot added the stale label Feb 17, 2024
@LingyuCoder
Copy link
Collaborator

supported webpackIgnore in #5172
supported webpackFetchPriority in #7029
supported webpackInclude and webpackExclude in #7055
supported webpackExports in #7198

all magic comments had been supported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stale team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Narretz @birtles @LingyuCoder @ahabhgk