Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rbac: casbin: adjust model to use keyMatch5 #6290

Merged
merged 19 commits into from
Nov 12, 2024
Merged

rbac: casbin: adjust model to use keyMatch5 #6290

merged 19 commits into from
Nov 12, 2024

Conversation

moogacs
Copy link
Contributor

@moogacs moogacs commented Nov 11, 2024

What's being changed:

Review checklist

  • Documentation has been updated, if necessary. Link to changed documentation:
  • Chaos pipeline run or not necessary. Link to pipeline:
  • All new code is covered by tests where it is reasonable.
  • Performance tests have been run or not necessary.

@moogacs moogacs changed the title rbac: casbin: adjust model to use globalMatch rbac: casbin: adjust model to use regexMatch Nov 11, 2024
@weaviate-git-bot
Copy link

Great to see you again! Thanks for the contribution.

beep boop - the Weaviate bot 👋🤖

PS:
Are you already a member of the Weaviate Slack channel?

@moogacs moogacs changed the title rbac: casbin: adjust model to use regexMatch rbac: casbin: adjust model to use keyMatch5 Nov 12, 2024
@moogacs moogacs marked this pull request as draft November 12, 2024 15:06
@moogacs moogacs marked this pull request as ready for review November 12, 2024 15:06
tsmith023
tsmith023 requested changes Nov 12, 2024
View reviewed changes
usecases/schema/tenant.go Outdated Show resolved Hide resolved
@moogacs moogacs requested a review from tsmith023 November 12, 2024 16:32
tsmith023
tsmith023 requested changes Nov 12, 2024
View reviewed changes
usecases/auth/authorization/types.go Outdated Show resolved Hide resolved
@moogacs moogacs requested a review from tsmith023 November 12, 2024 16:49
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@moogacs moogacs merged commit d5f05ea into feat/rbac Nov 12, 2024
53 checks passed
@moogacs moogacs deleted the casbin-model branch November 12, 2024 17:03
@BrewTestBot BrewTestBot mentioned this pull request Dec 11, 2024
Merged
ajit283 pushed a commit that referenced this pull request Dec 27, 2024
@moogacs
Merge pull request #6290 from weaviate/casbin-model
95e94d3 
rbac: casbin: adjust model to use keyMatch5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirkkul dirkkul dirkkul left review comments

@tsmith023 tsmith023 tsmith023 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@moogacs @weaviate-git-bot @dirkkul @tsmith023